[PATCH v2 0/2][SRU][C][D][E]AX88772A USB to Ethernet dongle doesn't work

[Stefan Bader]

On 01.07.19 03:44, AceLan Kao wrote:
> I just added the missing cosmic nomination, thanks.

You did but also set all the tasks to fix committed. This is wrong. The state is
not committed until we apply it to the tree.
> 
> I don't know how to check the d-i module lists, maybe you can give me
> some hints.

git grep asix debian.master/d-i/modules/
debian.master/d-i/modules/nic-usb-modules:asix ?

git grep ax88796b debian.master/d-i/modules/

returns nothing, which means the phy driver is not supported in the installer (I
don't know which one was picked up via the usb list, maybe the wrong one). So
maybe we can say here its not worse that before...

> This renamed driver is newly added after v4.18, and its name conflicts
> with the USB one,
> If the driver name, asix, listed in the d-i module lists, it should
> indicate the origin USB asix driver, not
> the newly added(renamed) driver. So, I think it's safe to rename it.
> 
> Stefan Bader <stefan.bader at canonical.com> 於 2019年6月29日 週六 上午12:03寫道：
>>
>> On 25.06.19 08:36, AceLan Kao wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1834114
>>>
>>> [Impact]
>>> There are 2 asix drivers in the kernel, they are drivers/net/usb/asix
>>> and drivers/net/phy/asix. It leads to the compilation race condition
>>> that one overwrites the other asix.mod in .tmp_version directory.
>>> This affects the USB dongle if the "phy" one wins.
>>>
>>> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 7 Spd=480 MxCh= 0
>>> D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=00 MxPS=64 #Cfgs= 1
>>> P: Vendor=0b95 ProdID=7720 Rev=00.01
>>> S: Manufacturer=ASIX Elec. Corp.
>>> S: Product=AX88772A
>>> S: SerialNumber=000527
>>> C: #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=250mA
>>> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=00 Driver=asix
>>>
>>> [Fix]
>>> The same name asix has been introduced since v4.18-rc1 by this commit
>>>    31dd83b96641 net-next: phy: new Asix Electronics PHY driver
>>> the new commit fix this issue by renaming it
>>>    a9520543b123 net: phy: rename Asix Electronics PHY driver
>>>
>>> [Test]
>>> Verified on my own ASIX USB Ethernet dongle.
>>>
>>> [Regression Potential]
>>> Low, it only rename the module name, no code change.
>>>
>>> AceLan Kao (1):
>>>   UBUNTU: [Config] update configs and annotations for ASIX renamed
>>>
>>> Michael Schmitz (1):
>>>   net: phy: rename Asix Electronics PHY driver
>>>
>>>  debian.master/abi/5.0.0-19.20/amd64/generic.modules      | 1 +
>>>  debian.master/abi/5.0.0-19.20/amd64/lowlatency.modules   | 1 +
>>>  debian.master/abi/5.0.0-19.20/arm64/generic.modules      | 1 +
>>>  debian.master/abi/5.0.0-19.20/armhf/generic-lpae.modules | 1 +
>>>  debian.master/abi/5.0.0-19.20/armhf/generic.modules      | 1 +
>>>  debian.master/abi/5.0.0-19.20/i386/generic.modules       | 1 +
>>>  debian.master/abi/5.0.0-19.20/i386/lowlatency.modules    | 1 +
>>>  debian.master/abi/5.0.0-19.20/ppc64el/generic.modules    | 1 +
>>>  debian.master/abi/5.0.0-19.20/s390x/generic.modules      | 1 +
>>>  debian.master/config/annotations                         | 2 +-
>>>  debian.master/config/config.common.ubuntu                | 2 +-
>>>  drivers/net/ethernet/8390/Kconfig                        | 2 +-
>>>  drivers/net/phy/Kconfig                                  | 2 +-
>>>  drivers/net/phy/Makefile                                 | 2 +-
>>>  drivers/net/phy/{asix.c => ax88796b.c}                   | 0
>>>  15 files changed, 14 insertions(+), 5 deletions(-)
>>>  rename drivers/net/phy/{asix.c => ax88796b.c} (100%)
>>>
>> You set the state of disco in the bug report to fix committed and there is no
>> cosmic nomination. So this is rather confusing.
>> Also, have you checked whether this renamed driver is matching one of the d-i
>> module lists and appears in the relevant udeb?
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190701/54704806/attachment.sig>