ACK/Cmnt: [SRU][PATCH 1/1][bionic-signed-hwe][PATCH] UBUNTU: move headers and sbsigntool depends to Build-Depends-Arch:

Stefan Bader stefan.bader at canonical.com
Mon Jul 1 14:57:53 UTC 2019


On 01.07.19 15:19, Stefan Bader wrote:
> On 27.06.19 06:03, Khalid Elmously wrote:
>> These may not be installed (and are not actually needed) in the source
>> package construction environment.
>>
>> Ignore: yes
>>
>> Suggested-by: Kamal Mostafa <kamal at canonical.com>
>> Signed-off-by: Khalid Elmously <khalid.elmously at canonical.com>
>> ---
> 
> While I believe this is the same in Disco, too, is there more to it than nice to
> have? Maybe even fixing some problem?

Ok, so this seems to be a requirement to allow automation to resolve any
dependencies needed to build a source package. And the build-depends-arch stage
is what is used for producing binary debs and therefor fixes the case of
automatically installing all build dependencies for the source package.

If we could make the committed versions of this changes slightly more verbose
(so to have somewhere to return when wondering why this was done) I am ok with this.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
> 
> -stefan
> 
>>  debian/control.stub | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/debian/control.stub b/debian/control.stub
>> index 1721803c..6ec804d7 100644
>> --- a/debian/control.stub
>> +++ b/debian/control.stub
>> @@ -7,6 +7,7 @@ Build-Depends:
>>   lsb-release,
>>   python3,
>>   python3-apt,
>> +Build-Depends-Arch:
>>   sbsigntool [amd64 arm64],
>>   HEADERS (>= UNSIGNED_SRC_VERSION),
>>  Standards-Version: 3.9.4
>>
> 
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190701/fbf6e447/attachment.sig>


More information about the kernel-team mailing list