ACK: [PATCH 0/1] [SRU] [B-C/raspi2] build CM3 dtb if (arch=arm64)
Colin Ian King
colin.king at canonical.com
Wed Jan 30 14:00:29 UTC 2019
On 29/01/2019 15:19, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1813133
>
> Impact:
>
> The dtb for the Raspberry CM3 board is not shipped in the Bionic -raspi2
> kernel arm64 variant.
>
> Fix:
>
> The dtb for the cm3 board was not compiled at all, in the arm64 arch -
> apply the attached patch and recompile.
>
> How to test:
>
> The linux-modules-*-raspi2_arm64.deb should contain the bcm2710-rpi-cm3
> dtb now:
>
> $ dpkg -x linux-modules-4.15.0-1031-raspi2_4.15.0-1031.33_arm64.deb
> foobar
> ...
> $ ls -l foobar/lib/firmware/4.15.0-1031-raspi2/device-tree/broadcom/
> total 92
> -rw-r--r-- 1 ppisati ppisati 24566 Jan 23 12:59 bcm2710-rpi-3-b-plus.dtb
> -rw-r--r-- 1 ppisati ppisati 24303 Jan 23 12:59 bcm2710-rpi-3-b.dtb
> -rw-r--r-- 1 ppisati ppisati 23015 Jan 23 12:59 bcm2710-rpi-cm3.dtb
> -rw-r--r-- 1 ppisati ppisati 17451 Jan 23 12:59 bcm2837-rpi-3-b.dtb
>
> Regression potential:
>
> The patch is trivial - it just builds the cm3 dtb if arch=arm64, and
> doesn't modify any code, so the regression potential is zero here.
>
> Patch applies cleanly to Cosmic/raspi2 too.
>
>
> Steve Pavao (1):
> devicetree: add RPi CM3 dts to arm64; mimic the RPi 3B arm64 dts
> implementation, by referring to the actual dts file in the arm
> directory
>
> arch/arm64/boot/dts/broadcom/Makefile | 2 ++
> arch/arm64/boot/dts/broadcom/bcm2710-rpi-cm3.dts | 3 +++
> 2 files changed, 5 insertions(+)
> create mode 100644 arch/arm64/boot/dts/broadcom/bcm2710-rpi-cm3.dts
>
Regression potential does appear to be low, and is from the upstream
raspi2 repo and had time to soak, so..
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the kernel-team
mailing list