[SRU] [B/C] [PATCH 0/4] Fix non-working pinctrl-intel

Kai Heng Feng kai.heng.feng at canonical.com
Tue Jan 22 16:31:13 UTC 2019



> On Jan 21, 2019, at 10:19 PM, Stefan Bader <stefan.bader at canonical.com> wrote:
> 
> On 15.01.19 10:02, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1811777
>> 
>> [Impact]
>> Intel pinctrl doesn't work.
>> There's a WWAN card needs to use pinctrl to reset itself after firmware
>> update. Currently we can't use pinctrl to reset it.
>> 
>> [Fix]
>> Translate GPIO to pinctrl pins correctly.
>> 
>> [Test]
>> The WWAN reset function works once the fix is applied.
>> 
>> [Regression Potential]
>> Low. Limits to pinctrl-intel and it's in mainline for a while.
>> 
>> Andy Shevchenko (1):
>>  pinctrl: intel: Do pin translation when lock IRQ
>> 
>> Javier Arteaga (1):
>>  pinctrl: intel: Implement intel_gpio_get_direction callback
>> 
>> Mika Westerberg (2):
>>  pinctrl: intel: Do pin translation in other GPIO operations as well
>>  Revert "pinctrl: intel: Do pin translation when lock IRQ"
>> 
>> drivers/pinctrl/intel/pinctrl-intel.c | 128 ++++++++++++++++----------
>> 1 file changed, 81 insertions(+), 47 deletions(-)
>> 
> Feels a bit silly to apply and revert something in one set (#2 and #4). I assume
> that is to make patch #3 apply without modification?

You are right. Resent v2 to address the obvious issue.

Kai-Heng 

> 
> -Stefan
> 




More information about the kernel-team mailing list