[B][SRU][PATCH 0/3] selftests: user: return Kselftest Skip code for skipped tests
Po-Hsu Lin
po-hsu.lin at canonical.com
Fri Jan 18 09:11:16 UTC 2019
BugLink: https://bugs.launchpad.net/bugs/1812198
== Justification ==
This user_copy test has failed while attempting to insert the
test_user_copy module, but this module does not exist in the Bionic KVM
kernel as the CONFIG_TEST_USER_COPY was not enabled.
# modprobe test_user_copy
modprobe: FATAL: Module test_user_copy not found in directory /lib/modules/4.15.0-1028-kvm
== Fix ==
d7d5311 (selftests: user: return Kselftest Skip code for skipped tests)
3c07aae (selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS)
c31d02d (selftests: kselftest: Remove outdated comment)
This fix will make the test return a skipped retun code if the
test_user_copy module does not exist.
This patch set can be cherry-picked into Bionic, and we already have it
in Cosmic / Disco.
For Xenial, it already got d7d5311 and does not need the other two.
== Test ==
With this patch, the test will return "skipped" as expected:
$ sudo ./test_user_copy.sh
user: module test_user_copy is not found [SKIP]
$ echo $?
4
Note that the test framework will need another fix to treat the SKIP
return code properly. (bug 1812352)
== Regression potential ==
None,
this patch just change the code for the testing tool.
Shuah Khan (Samsung OSG) (2):
selftests: user: return Kselftest Skip code for skipped tests
selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS
Thiago Jung Bauermann (1):
selftests: kselftest: Remove outdated comment
tools/testing/selftests/kselftest.h | 3 +--
tools/testing/selftests/user/test_user_copy.sh | 7 +++++++
2 files changed, 8 insertions(+), 2 deletions(-)
--
2.7.4
More information about the kernel-team
mailing list