NAK: [Bionic][deb-to-snap master][Patch] deb to snap: install updates before building

Kleber Souza kleber.souza at canonical.com
Fri Jan 11 14:53:27 UTC 2019


On 12/17/18 11:51 AM, Robert Liu wrote:
> BugLink: https://launchpad.net/bugs/1808768
>
> Install updates after deboostrap to avoid using out-of-date packages.
>
> Signed-off-by: Robert Liu <robert.liu at canonical.com>
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 0a9a7c4..c60d6a4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -67,6 +67,9 @@ install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinu
>  all:
>  	debootstrap --variant=minbase $(RELEASE) chroot
>  	cp /etc/apt/sources.list chroot/etc/apt/sources.list
> +	# install all updates
> +	$(ENV) chroot chroot apt-get -y update
> +	$(ENV) chroot chroot apt-get -y upgrade
>  	echo "deb http://ppa.launchpad.net/snappy-dev/image/ubuntu $(RELEASE) main" >> chroot/etc/apt/sources.list
>  	if [ "$(PROPOSED)" = "true" ]; then \
>  	  echo "deb http://$(MIRROR) $(RELEASE)-proposed main restricted" >> chroot/etc/apt/sources.list; \

This patch has been re-submitted, ack'ed and applied. So this one can be
ignored.


Thanks,
kleber




More information about the kernel-team mailing list