ACK/cmnt: [SRU][B/OEM-B/C/D][PATCH 0/1] audio output has constant noise on a Dell machine

[Kai Heng Feng]

> On Jan 9, 2019, at 9:35 AM, Hui Wang <hui.wang at canonical.com> wrote:
> 
> On 2019/1/8 下午10:24, Kleber Souza wrote:
>> On 1/8/19 7:28 AM, Hui Wang wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1810891
>>> 
>>> [Impact]
>>> the audio output (headpohne, lineout and internal speaker) has constant
>>> noise when playing sound.
>>> 
>>> [Fix]
>>> Set the pin configuration and some secret coeff registers, the noise
>>> disappears. This patch is written by Realtek engineer and is upstreamd
>>> already.
>>> 
>>> 
>>> [Test Case]
>>> play sound via internal speaker, lineout and headphone, no noise anymore.
>>> 
>>> 
>>> [Regression Potential]
>>> Very low, this patch is upstreamd for a while, no regression is reported.
>>> 
>>> 
>>> Kailang Yang (1):
>>>   ALSA: hda/realtek - Fixed headphone issue for ALC700
>>> 
>>>  sound/pci/hda/patch_realtek.c | 33 +++++++++++++++++++++++++++++++++
>>>  1 file changed, 33 insertions(+)
>>> 
>> Hi Hui Wang,
>> 
>> Why there's a separate patch for D? Both patches state they were
>> cherry-picked, if that was the case the same patch could have been
>> submitted for all the requested series. If that's not the case, i.e. for
>> some of the series doing a 'git am' with the same patch would not work,
>> then that patch needs to be flagged as "backported from" instead of
>> "cherry picked from".
> 
> At first, I cherry-picked this patch under bionic kernel, then git format the patch, and git am the patch to cosmic, there is no error. But when I git am the patch to disco, there are errors. Then I cherry-picked this commit under disco kernel, there is no error. As a result, I sent the 1st cherry-picked patch for B/C and sent the 2nd cherry-picked patch for D.

I also met this situation a while back. Formatted patch cannot be applied
to other releases, but it’s considered clean cherry-pick by git.

Kai-Heng

> 
> Thanks.
> 
>> 
>> Anyway this is a minor issue and the patches look good.
>> 
>> 
>> Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
>> 
>> 
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team