ACK: [PATCH 0/2][SRU][B][C] Ethernet[10ec:8136] doesn't work after S3 with kernel 4.15.0.43.64

[Kleber Souza]

On 12/27/18 4:17 AM, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1809847
>
> [Impact]
> The Realtek Ethernet[10ec:8136] works after S3 with kernel 4.15.0-33.36,
> and fails with kernel 4.15.0.43.64. There is no interrupt while
> plug/unplug Ethernet cable after S3, so it looks like an regression after
> 4.15.0-33.36.
>
> [Fix]
> Check changelog and found there are 2 commits introduced from
> 4.15.0-35.38 might be suspicious
>   * r8169 no internet after suspending (LP: #1779817)
>     - r8169: don't use MSI-X on RTL8168g
>     - r8169: don't use MSI-X on RTL8106e
> And check the upstream log and found the 2 MSI-X commits had been all
> reverted, since below commit claims it fixes the MSI-X interrupt issue
> which is already in Bionic kernel.
>    083874549fdf PCI: Reprogram bridge prefetch registers on resume
> So, I reverted the 2 MSI-X commits and found the Ethernet works again
> after S3.
>
> [Regression Potential]
> Low, the 2 disable MSI-X commits are workarounds, and now we have a proper
> way to fix the issue, so it should be fine to revert them.
>
> AceLan Kao (1):
>   UBUNTU: SAUCE: Revert "r8169: don't use MSI-X on RTL8106e"
>
> Heiner Kallweit (1):
>   r8169: re-enable MSI-X on RTL8168g
>
>  drivers/net/ethernet/realtek/r8169.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>
The reverts look reasonable.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>