ACK/Cmnt: [PATCH 0/4][SRU][B][C][OEM-B]SATA device is not going to DEVSLP

[Stefan Bader]

On 28.11.18 10:19, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1781533
> 
> [Impact]
> Any of the platforms we’ve been seeing SATA problems not going to deepest
> state leads to other devices not getting there during long idle or s2idle.
> And it also prevents the system from entering deeper PC state other than
> PC3.
> 
> [Fix]
> Suggested from Intel and Dell to contains the following 4 commits,
> and all of 4 commits are in v4.19-rc1
> https://patchwork.kernel.org/patch/10502285/
> https://patchwork.kernel.org/patch/10502287/
> https://patchwork.kernel.org/patch/10535781/
> https://patchwork.kernel.org/patch/10535783/
> 
> [Test]
> Verified the power consumption on some new platforms, it improves the
> SATA HDD power consumption around 0.5w during long idle.
> 
> [Regression Potential]
> Low, the DEVSLP function is already validated when shipped with SLP_S0
> support.
> 
> Srinivas Pandruvada (4):
>   ata: ahci: Support state with min power but Partial low power state
>   ata: ahci: Enable DEVSLP by default on x86 with SLP_S0
>   ata: libahci: Correct setting of DEVSLP register
>   ata: libahci: Allow reconfigure of DEVSLP register
> 
>  drivers/ata/ahci.c        | 38 +++++++++++++++++++++++++++++++++-----
>  drivers/ata/libahci.c     | 25 ++++++++++++++++---------
>  drivers/ata/libata-core.c |  1 +
>  drivers/ata/libata-scsi.c |  1 +
>  include/linux/libata.h    |  3 ++-
>  5 files changed, 53 insertions(+), 15 deletions(-)
> 
From looking at this I take it that the default from the new config is to leave
things as they were if not changed by command line. At least if SLP_S0 only
exists with newer hardware which than gets validated using the new support.

Just some notes for
a) probably needs an updateconfigs run and the new config default added to a
commit after the set has been applied in bionic.
b) some care when committing as some re-send was done as a re-ply to the same
thread for cosmic (might be easy to miss the way thunderbird shows that to me).

otherwise:

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190107/8089b067/attachment.sig>