[OEM][PATCH 0/2] Revert i2c-designware commits for issues on CHT platforms
Wen-chien Jesse Sung
jesse.sung at canonical.com
Wed Jan 2 02:02:50 UTC 2019
BugLink: https://launchpad.net/bugs/1810223
== Impact ==
The i2c-designware stops working after S4 thus I2C devices connected to it can't be accessed.
[ 272.628526] PM: Timekeeping suspended for 115.313 seconds
[ 272.633110] ACPI: Waking up from system sleep state S4
[ 272.655524] PM: noirq restore of devices complete after 19.377 msecs
[ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: 0xffffffff
[ 272.876322] PM: early restore of devices complete after 219.859 msecs
...
[ 273.060760] i2c_designware 80860F41:00: timeout waiting for bus ready
[ 274.214314] i2c_designware 80860F41:00: timeout in disabling adapter
== Fix ==
This happens after these two commits:
* 36c27d206b21 - PM: i2c-designware-platdrv: Optimize power management (2018-12-07 16:21:11 +0800)
* 489cd2fafa2d - PM: i2c-designware-platdrv: Use DPM_FLAG_SMART_PREPARE (2018-12-07 16:21:11 +0800)
Until there's a proper fix for them, both of them need to be reverted in order to make S4 works again.
== Test Case ==
Boot with the kernel, S4, and then wake the system up.
== Risk of Regression ==
Risk should be low since we're removing new features.
Wen-chien Jesse Sung (2):
Revert "PM: i2c-designware-platdrv: Optimize power management"
Revert "PM: i2c-designware-platdrv: Use DPM_FLAG_SMART_PREPARE"
drivers/i2c/busses/i2c-designware-core.h | 2 ++
drivers/i2c/busses/i2c-designware-platdrv.c | 39 ++++++++++-----------
2 files changed, 21 insertions(+), 20 deletions(-)
--
2.19.1
More information about the kernel-team
mailing list