ACK/Cmnt: [SRU] [B] [PATCH 0/1] Fix touchpad on Walmart Overpowered laptop

Stefan Bader stefan.bader at canonical.com
Wed Feb 27 15:12:37 UTC 2019


On 27.02.19 15:15, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817200
> 
> [Impact]
> Touchpad on Walmart Overpowered laptop doesn't work.
Curious, is ^that its official title??
> 
> [Fix]
> Quote the commit message:
> "The gpio base for GPP-E was set incorrectly to 258 instead of 256"
> 
> [Test]
> User confirm the commit makes the touchpad work.
> 
> [Regression Potential]
> Low. This commit is in upstream stable for a while.

Probably in this case acceptable. But from the change it modifies some magic
number in some mysterious array of some random (ok, not that much) driver. Is
that GPIO more consistent for the same HW than say in ALSA?

Anyway: Acked-by: Stefan Bader <stefan.bader at canonical.com>
> 
> Simon Detheridge (1):
>   pinctrl: cannonlake: Fix gpio base for GPP-E
> 
>  drivers/pinctrl/intel/pinctrl-cannonlake.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190227/96b80323/attachment.sig>


More information about the kernel-team mailing list