ACK: [SRU] [Unstable] [PATCH 0/2] Fix for LP: #1815733

[Alex Hung]

On 2019-02-22 5:07 a.m., Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1815733
> 
> [Impact]
> Quote from the bug description:
> "
> This behavior affects production systems, because every change uevent
> triggers udev to change settings prior to udev rules. Some software, for
> example arcconf (tool for managing adaptec HBA adapters) triggers
> uevents for every block device. So, every call to arcconf utility
> results in latency spike.
> "
> 
> [Fix]
> Avoid unnecessary queue freeze in either one of the case:
>  - the queue depth is about to be set to the same value, or 
>  - scheduler is "none" and is about to be set to "none" again.
> 
> [Test]
> The user confirm these two patches works.
> 
> [Regression Potential]
> Medium. Both patches looks sane, but they are still in -next but not
> mainline linux. Let's backport these patches to unstable before making
> them in Bionic/Cosmic.
> 
> Aleksei Zakharov (2):
>   block: avoid setting nr_requests to current value
>   block: avoid setting none scheduler if it's already none
> 
>  block/blk-mq.c   | 3 +++
>  block/elevator.c | 5 ++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 


Acked-by: Alex Hung <alex.hung at canonical.com>