[SRU] [Unstable/OEM-B] [PATCH 0/2] r8169 doesn't get woken up by ethernet cable plugging, no PME generated

Kai-Heng Feng kai.heng.feng at canonical.com
Tue Feb 26 08:56:55 UTC 2019


BugLink: https://bugs.launchpad.net/bugs/1817676

[Impact]
Once r8169 (Realtek ethernet) and its root port enter to D3, plugging
network cable doesn't wake r8169 up.

[Fix]
Revert "PCI/PME: Implement runtime PM callbacks".
Quote the original commit message:
"
The commit tried to prevent root port waking up from D3cold immediately but
looks like disabing root port PME interrupt is not the right way to fix
that issue so revert it now.  The patch following proposes an alternative
solution to that issue.
"

[Test]
After applying the fix, plugging the ethernet cable can generate PME IRQ
correctly, hence waking up r8169.

[Regression Potential]
Medium. The commits are relative new, rely on some PCI detail that I am
not familiar with (PCI spec isn't publicly available).
Fortunately we only need this fix for Unstable/OEM-B, so it won't hit
most users if any regression happens.

Mika Westerberg (2):
  Revert "PCI/PME: Implement runtime PM callbacks"
  PCI: pciehp: Disable Data Link Layer State Changed event on suspend

 drivers/pci/hotplug/pciehp_hpc.c | 17 +++++++++++++++--
 drivers/pci/pcie/pme.c           | 27 ---------------------------
 2 files changed, 15 insertions(+), 29 deletions(-)

-- 
2.17.1




More information about the kernel-team mailing list