ACK: [SRU][B/C/D/unstable][PATCH v2 0/1] Fix the constant noise of headphone on lenovo X1 machines

Seth Forshee seth.forshee at canonical.com
Fri Feb 22 10:53:09 UTC 2019


On Fri, Feb 22, 2019 at 06:33:03PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817263
> 
> In the V2, I regenerated the patch based on the master-next branch of Disco, only the
> 0001-xxx.patch for Disco is changed in the V2, other patches are same as V1.
> 
> [Impact]
> It is reported that there is constant noise on lenovo X1 machines, and after
> investigating, I found this issue will happen on all Lenovo machines with the
> codec alc285.
> 
> [Fix]
> According to Realtek's comment, the noise comes from PC peeb in, after
> disable this pin or disable the passthrough of this pin will fix the
> problem.
> 
> [Test Case]
> After applying this patch, we play sound on Lenovo P52, P72, X1 carbon and X1
> Yoda2, no noise anymore. And this patch is confirmed to work by many other
> users too (https://bugzilla.redhat.com/show_bug.cgi?id=1660581,
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805079/comments/38).
> 
> [Regression Potential]
> Low. This patch only apply to several lenovo machines, and it is tested
> by many users already.

Positive testing, limited scope. Backports look good.

Acked-by: Seth Forshee <seth.forshee at canonical.com>



More information about the kernel-team mailing list