[Disco][SRU][PATCH 1/2] RAS/CEC: Increment cec_entered under the mutex lock

Po-Hsu Lin po-hsu.lin at canonical.com
Tue Dec 31 09:53:25 UTC 2019


From: WANG Chao <chao.wang at ucloud.cn>

BugLink: https://bugs.launchpad.net/bugs/1857413

Modify ->cec_entered in the critical section of the mutex.

Signed-off-by: WANG Chao <chao.wang at ucloud.cn>
Signed-off-by: Borislav Petkov <bp at suse.de>
Cc: Tony Luck <tony.luck at intel.com>
Cc: linux-edac <linux-edac at vger.kernel.org>
Link: https://lkml.kernel.org/r/20190418034115.75954-2-chao.wang@ucloud.cn
(cherry picked from commit 09cbd2197e9291d6a3d3f42873f06ca1f388c1a4)
Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
---
 drivers/ras/cec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 5d2b2c02..f5795ad 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -290,10 +290,10 @@ int cec_add_elem(u64 pfn)
 	if (!ce_arr.array || ce_arr.disabled)
 		return -ENODEV;
 
-	ca->ces_entered++;
-
 	mutex_lock(&ce_mutex);
 
+	ca->ces_entered++;
+
 	if (ca->n == MAX_ELEMS)
 		WARN_ON(!del_lru_elem_unlocked(ca));
 
-- 
2.7.4




More information about the kernel-team mailing list