[PATCH 4/5][SRU Bionic] md/raid0: Fix an error message in raid0_make_request()

dann frazier dann.frazier at canonical.com
Wed Dec 18 14:31:25 UTC 2019


From: Dan Carpenter <dan.carpenter at oracle.com>

BugLink: https://bugs.launchpad.net/bugs/1850540

[ Upstream commit e3fc3f3d0943b126f76b8533960e4168412d9e5a ]

The first argument to WARN() is supposed to be a condition.  The
original code will just print the mdname() instead of the full warning
message.

Fixes: c84a1372df92 ("md/raid0: avoid RAID0 data corruption due to layout confusion.")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Song Liu <songliubraving at fb.com>
Signed-off-by: Sasha Levin <sashal at kernel.org>
Signed-off-by: dann frazier <dann.frazier at canonical.com>
---
 drivers/md/raid0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index ffbd6cb93ee82..23fb20a042a42 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -619,7 +619,7 @@ static bool raid0_make_request(struct mddev *mddev, struct bio *bio)
 		tmp_dev = map_sector(mddev, zone, sector, &sector);
 		break;
 	default:
-		WARN("md/raid0:%s: Invalid layout\n", mdname(mddev));
+		WARN(1, "md/raid0:%s: Invalid layout\n", mdname(mddev));
 		bio_io_error(bio);
 		return true;
 	}
-- 
2.24.1




More information about the kernel-team mailing list