[PATCH 0/2][SRU][unstable][E] The system cannot resume from S3 if user unplugs the TB16 during suspend state

AceLan Kao acelan.kao at canonical.com
Tue Dec 10 02:34:58 UTC 2019


BugLink: https://bugs.launchpad.net/bugs/1849269

[Impact]
Unplug TBT dock during S3 and then wakes up the system leads to system
hangs. This not only happens on Dell TB16, but also Dell WD19TB. It's
more like a BIOS or TBT firmware issue that TBT firmware doesn't
re-create the PCIe tunnels.

[Fix]
Mika provides 4 patches to fix this issue, but only 2 were accepted.
Now the reset 2 commits has been included in v5.5, so backport them
to Ubuntu kernel.

[Test]
Verified on Dell Precision 5530 + WD19TB

[Regression Potential]
Low, those patches doesn't change the code path much. The final commit
adds some checks to return failure state, and it should be safe for
those machines which are already working well.

Mika Westerberg (2):
  PCI: pciehp: Do not disable interrupt twice on suspend
  PCI: pciehp: Prevent deadlock on disconnect

 drivers/pci/hotplug/pciehp.h      |  6 ++--
 drivers/pci/hotplug/pciehp_core.c | 36 ++++++++++++++++---
 drivers/pci/hotplug/pciehp_ctrl.c |  4 +--
 drivers/pci/hotplug/pciehp_hpc.c  | 59 +++++++++++++++++++++++++------
 4 files changed, 84 insertions(+), 21 deletions(-)

-- 
2.17.1




More information about the kernel-team mailing list