[Bionic][SRU][PATCH 0/1] UBUNTU: SAUCE: Revert "crypto: testmgr - add AES-CFB

[Connor Kuehl]

https://bugs.launchpad.net/bugs/1841264

[Impact]
Ubuntu commit aae817ffb114 "crypto: testmgr - add AES-CFB tests" added new
test cases to the crypto self-tests. This patch is referring to structure
members that don't exist in Bionic because the large mainline clean up patch
92a4c9fef34c crypto: "testmgr - eliminate redundant decryption test vectors"
has not been backported.

[Fix]
Revert Ubuntu commit aae817ffb114 "crypto: testmgr - add AES-CFB tests" as
the backport is large and error prone. The backport will not be accepted at this
time.

[Test Case]
On a Bionic kernel, ensure "CONFIG_CRYPTO_MANAGER_DISABLE_TESTS" is NOT set and
ensure you have the patch in your tree (master-next should have it as of this
writing it has not been reverted).

To disable that config option, edit debian.master/config/config.common.ubuntu and
delete the line that reads "CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=y" then update the
configs with "fakeroot debian/rules updateconfigs"

Build the kernel.

Expected result: crypto/testmgr.o is built successfully and so is the rest of the kernel for your build.

Actual result: crypto/testmgr.o fails to build with several errors related to data members of a structure that don't exist yet. Like this:

/tmp/kernel-connork-cb14cb8-q7j8/build/crypto/testmgr.h:16148:4: error: 'const struct cipher_testvec' has no member named 'ptext'
   .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96"
    ^~~~~
/tmp/kernel-connork-cb14cb8-q7j8/build/crypto/testmgr.h:16156:4: error: 'const struct cipher_testvec' has no member named 'ctext'
   .ctext = "\x3b\x3f\xd9\x2e\xb7\x2d\xad\x20"
    ^~~~~
/tmp/kernel-connork-cb14cb8-q7j8/build/crypto/testmgr.h:16164:4: error: 'const struct cipher_testvec' has no member named 'len'; did you mean 'klen'?
   .len = 64,

[Regression Potential]
Very low. This reverts a patch that added crypto tests that do not compile.
Furthermore, these tests rely on a module, CFB, which is loaded at run-time
for the test suite. This module has not been added to the Bionic kernel,
and so even if the tests DID compile, they would not be able to run.

Connor Kuehl (1):
  UBUNTU: SAUCE: Revert "crypto: testmgr - add AES-CFB tests"

 crypto/tcrypt.c  |  5 ----
 crypto/testmgr.c |  7 -----
 crypto/testmgr.h | 76 ------------------------------------------------
 3 files changed, 88 deletions(-)

-- 
2.17.1