ACK/Cmnt: [SRU][Bionic][PATCH] tuntap: correctly set SOCKWQ_ASYNC_NOSPACE

[Nicolas Dichtel]

Le 28/08/2019 à 17:24, Stefan Bader a écrit :
> On 28.08.19 15:48, Nicolas Dichtel wrote:
>> Le 27/08/2019 à 17:04, Stefan Bader a écrit :
>>> On 26.08.19 19:14, Kamal Mostafa wrote:
>>>> 1bd4978a88ac2 ("tun: honor IFF_UP in tun_get_user()")
>>>
>>> Normally bug reports for SRU should have a justification section like I have
>>> added now for this one. Ideally with a test case (or steps how something can be
>>> verified). If someone could do the same for the ipv6 neighbour resolution
>>> request. Thanks
>>
>> The description and the test case are explained in the commit log, it's just a
>> copy and paste. But what do you expect in the "Fix" section?
>> For now, the fix has only been backported in disco. I was checking bionic but
>> not xenial 4.4.
> 
> Fix usually is just stating what is required to fix the issue. Here just the
> patch you propose. The whole justification is coming from general stable release
> update procedures and is geared towards people which are not necessarily kernel
> people. In the case at hand I would probably add more details which kernel
> version the fix comes from and which kernel versions potentially are needing
> this. (Introduced with ... , maybe/likely 4.4 got it via some upstream stable)
I've added this SRU:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1834465

Feel free to update it if needed.


Regards,
Nicolas