ACK/CMNT: [SRU][Bionic][PATCH 1/1] Revert "selftests: skip seccomp get_metadata test if not real root"

[Kleber Souza]

On 8/22/19 3:40 PM, Thadeu Lima de Souza Cascardo wrote:
> On Thu, Aug 22, 2019 at 03:34:42PM +0200, Kleber Sacilotto de Souza wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1840932
>>
>> This reverts commit c33a23ff8ffcb8800bd2628f2af308a43496590f.
>>
>> Commit upstream 3aa415dd2128 (selftests: skip seccomp get_metadata test if

The upstream commit is mentioned here ^

>> not real root) depends on d057dc4e35e1 (seccomp: add a selftest for
>> get_metadata), but the latter has been reverted on bionic as part of
>> LP #1837664. The get_metadata testcase doesn't exist anymore, the backport
>> of the patch ended up changing syscall_restart instead.
>>
>> Revert c33a23ff8ffc, which is not needed and is causing trouble.
>>
>> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>
> 
> Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> 
> Shouldn't this be UBUNTU: SAUCE:, or at least refer to the upstream commit
> 3aa415dd2128e478ea3225b59308766de0e94d6b?

Since we don't have a upstream sha1 for the revert I agree we should probably
add 'UBUNTU: SAUCE:' to the subject.

Thanks,
Kleber