glitch in your port of "drm/i915: Mark up GTT sizes as u64"
Timo Aaltonen
tjaalton at ubuntu.com
Fri Aug 16 10:11:22 UTC 2019
On 16.8.2019 0.42, Kamal Mostafa wrote:
> Hi Timo-
>
> It appears that your backport of this commit introduces a new compiler
> warning:
>
> [bionic] d6edad3777c2 drm/i915: Mark up GTT sizes as u64
> (backported from commit 9125963a9494253fa5a29cc1b4169885d2be7042)
> Signed-off-by: Timo Aaltonen <timo.aaltonen at canonical.com
> <mailto:timo.aaltonen at canonical.com>>
>
> /tmp/kernel-kamal-bfcb15d-CSRn/build/drivers/gpu/drm/i915/i915_gem_gtt.c:1669:28:
> warning: format '%llx' expects argument of type 'long long unsigned
> int', but argument 3 has type 'long unsigned int' [-Wformat=]
> seq_printf(m, "\t\t0x%llx [%03d,%04d]: =", va, pde, pte);
> ~~~^
> %lx
>
> I think the extension to %llx there just shouldn't have been applied in
> the backport, and should get put back to %lx. Take a look? Thanks!
>
> -Kamal
Sigh.. yeah, this was a poor attempt to backport the commit fully, since
4.15 doesn't have e9e7dc4144c. I missed this warning while fixing
another one.
--
t
More information about the kernel-team
mailing list