NACK: [linux-snap][bionic][PATCH] trusted.gpg.d directly supports .asc keys without gnupg/agent/etc.

[Dimitri John Ledkov]

On Mon, 12 Aug 2019 at 14:05, Stefan Bader <stefan.bader at canonical.com> wrote:
>
> If we remember till then, this is something for doing better in core20
>

Speaking of core20, where are the unstable repos for all kernel snaps
building out of $devel series?

I do not see any repositories but bionic, hence targetted the only
place that appears to accept commits for linux-snap....

> >  Sample build with this change in place is shown at:
> >  https://launchpad.net/~xnox/+snap/pc-kernel-bionic/+build/633218
> >
> >  Makefile | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index b2c5ea5..00d3b25 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -93,14 +93,7 @@ all:
> >
> >       # Enable ppa:snappy-dev/image inside of the chroot and add the PPA's
> >       # public signing key to apt:
> > -     # - gnugpg is required by apt-key
> > -     # - gnugpg 2.x requires gpg-agent to be running
> > -     # - procfs must be bind-mounted for gpg-agent
> > -     # - running apt-key as a child process of gpg-agent --daemon stops the
> > -     #   agent shortly after apt-key executes
> > -     $(ENV) chroot chroot apt-get -y install gnupg
> > -     mkdir --mode=0600 chroot/tmp/gnupg-home
> > -     cat snappy-dev-image.asc | $(ENV) chroot chroot gpg-agent --homedir /tmp/gnupg-home --daemon apt-key add -
> > +     cp snappy-dev-image.asc chroot/etc/apt/trusted.gpg.d/
> >       # Copy in the sources.list just before modifying it (on build envs this already
> >       # seems to be present, otherwise those would not fail).
> >       cp /etc/apt/sources.list chroot/etc/apt/sources.list
> >
>
>


-- 
Regards,

Dimitri.