NAK: [B][D][E][SRU][PATCH 0/1] Enable VIMC module

[Po-Hsu Lin]

Hi Seth,
nice to know we have this rule.

A side note is that for now we don't have any test that depends on
this module (perhaps we can investigate for one in the future, after
knowing such driver exists), should we keep going and enable this?

Thanks
Sam


On Thu, Aug 8, 2019 at 11:16 PM Seth Forshee <seth.forshee at canonical.com> wrote:
>
> On Thu, Aug 01, 2019 at 12:03:59PM +0800, Po-Hsu Lin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1831482
> >
> > == SRU Justification ==
> > VIMC is a virtual media controller that can emulate a real media device.
> > This is useful for automated tests, and development of multimedia frameworks.
> >
> > == Fix ==
> > Enable VIMC as a module in B/D/E kernel configs.
> >
> > == Test ==
> > Test kernels could be found here:
> > https://people.canonical.com/~phlin/kernel/lp-1831482-cfg-vimc/
> >
> > User has reported that the Eoan kernel works as expected.
> > I have also smoke tested the B/D kernel to make sure the VIMC modules
> > can be loaded properly.
> >
> > == Regression Potential ==
> > Low, this patchset just enable the VIMC module support.
>
> As a rule we don't enable these sorts of drivers as they are generally
> only meant for developers, who generally will be building their own
> kernels anyway. But if this one will be used for automated tests then it
> makes sense to enable it.
>
> However we should also update the annotations file to note the bug
> number which explains why we've enabled it. Can you resend this with the
> annotations update?
>
> Thanks,
> Seth