ACK/Cmnt: [PATCH 0/2][SRU][D] drm/i915: Fix hotplug issues

[Connor Kuehl]

On 7/23/19 12:39 AM, You-Sheng Yang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1835001
> 
> [Impact]
> System does not always auto detect disconnection of external monitor on
> Intel VGA.
> 
> [Fix]
> Two changes from drm-intel tree are necessary to introduce hotplug
> retrying to fix this issue. They are:
> 
>   * drm/i915: Add support for retrying hotplug
>   * drm/i915: Enable hotplug retry
> 
> [Test Case]
> 1. open "system settings > display settings"
> 2. connect laptop to an external HDMI monitor via HDMI port & cable
> 3. unplug the HDMI cable
> 4. check if "display settings" automatically detects the removal of the
> external monitor
> 
> [Regression potential]
> Medium. For all the prerequisites they have been landed since 4.18, and
> these two patches will only be merged some time later. Basically it
> turns a currently existing kernel work to a delayed work so that it may
> retry probing HDMI hotplug status.
> 
> Imre Deak (1):
>   drm/i915: Add support for retrying hotplug
> 
> José Roberto de Souza (1):
>   drm/i915: Enable hotplug retry
> 
>  drivers/gpu/drm/i915/i915_debugfs.c  |  2 +-
>  drivers/gpu/drm/i915/i915_drv.h      |  3 +-
>  drivers/gpu/drm/i915/intel_ddi.c     | 33 +++++++++++++---
>  drivers/gpu/drm/i915/intel_dp.c      | 19 ++++++---
>  drivers/gpu/drm/i915/intel_drv.h     | 16 ++++++--
>  drivers/gpu/drm/i915/intel_hdmi.c    | 28 ++++++++++++-
>  drivers/gpu/drm/i915/intel_hotplug.c | 59 ++++++++++++++++++++++------
>  drivers/gpu/drm/i915/intel_sdvo.c    |  8 ++--
>  8 files changed, 135 insertions(+), 33 deletions(-)
> 

I think since these patches come from an upstream maintainer's tree,
their commit subjects should have "(upstream)" in them [1].

Aside from that, with positive test results:

Acked-by: Connor Kuehl <connor.kuehl at canonical.com>

[1] https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat