[EOAN][UNSTABLE][PATCH] UBUNTU: SAUCE: arm64: dts: qcom: Add support for AArch64 laptops

Seth Forshee seth.forshee at canonical.com
Thu Aug 8 15:10:39 UTC 2019

On Tue, Jul 30, 2019 at 03:28:05PM -0400, Dimitri John Ledkov wrote:
> From: AArch64 Laptops <aarch64laptops at gmail.com>
> This is squashed merged of multiple patches from
> https://github.com/aarch64-laptops/linux/tree/laptops-ubuntu
> Note that some of these, with different names are getting upstreamed
> targetted for v5.4. Once those are all merged and available, this
> patch will become obsolete and will be dropped.

Are they in linux-next or a maintainer tree already? If so I think it
would be preferable to cherry pick the individual patches.

Otherwise, adding some device trees seems pretty harmless. But one
comment ...


> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index b2c2d01d1637..aa0272497be4 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -207,7 +207,7 @@ static int rpmh_regulator_is_enabled(struct regulator_dev *rdev)
>  {
>  	struct rpmh_vreg *vreg = rdev_get_drvdata(rdev);
> -	return vreg->enabled;
> +	return vreg->enabled > 0;
>  }

This is clearly a bug in the driver. I think it should be a separate
patch from the dts files, and it should be able to go into 5.3.


More information about the kernel-team mailing list