NACK: [SRU][X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Seth Forshee seth.forshee at canonical.com
Tue Apr 23 20:43:20 UTC 2019


On Tue, Apr 23, 2019 at 10:24:19AM -0700, Connor Kuehl wrote:
> NACK'ing this for Xenial because of the spelling error that I didn't
> catch. Will send a v2.

This implies that you didn't run 'cranky updateconfigs' after your
config changes, which you should always do. For instance, I tried your
patch for disco and got prompted for several additional options. So that
patch at least needs to be updated, it's likely that the others will as
well.

Thanks,
Seth

> 
> On 4/23/19 9:49 AM, Connor Kuehl wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1799791
> > 
> > This option was initially turned off as part of the minimal KVM config.
> > However, it is enabled in the master/generic config and its enablement
> > could allow for some creative applications of linux-kvm.
> > 
> > Signed-off-by: Connor Kuehl <connor.kuehl at canonical.com>
> > ---
> >  debian.kvm/config/config.common.ubuntu | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> > index cbdfe860ef82..d2e04d179f61 100644
> > --- a/debian.kvm/config/config.common.ubuntu
> > +++ b/debian.kvm/config/config.common.ubuntu
> > @@ -1100,7 +1100,8 @@ CONFIG_KERNEL_GZIP=y
> >  # CONFIG_KERNEL_LZO is not set
> >  # CONFIG_KERNEL_XZ is not set
> >  CONFIG_KERNFS=y
> > -# CONFIG_KEXEC is not set
> > +CONFIG_KEXEC=y
> > +COFNIG_KEXEC_FILE=y
> >  CONFIG_KEYS=y
> >  CONFIG_KEYS_COMPAT=y
> >  # CONFIG_KGDB is not set
> > 
> 

pub   RSA 4096/1FE09B94 2019-04-01 Connor Kuehl <connor.kuehl at canonical.com>
> sub   RSA 4096/0E9A453C 2019-04-01
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team




More information about the kernel-team mailing list