ACK/cmnt: [x/azure][PATCH] blk-mq: remove the request_list usage

Kleber Souza kleber.souza at canonical.com
Tue Apr 23 13:25:35 UTC 2019


On 4/22/19 10:32 PM, Marcelo Henrique Cerri wrote:
> From: Jens Axboe <axboe at kernel.dk>
> 
> BugLink: http://bugs.launchpad.net/bugs/1819689
> 
> We don't do anything with it, that's just the legacy path.
> 
> Reviewed-by: Hannes Reinecke <hare at suse.com>
> Tested-by: Ming Lei <ming.lei at redhat.com>
> Reviewed-by: Omar Sandoval <osandov at fb.com>
> Signed-off-by: Jens Axboe <axboe at kernel.dk>
> (backported from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
> [marcelo.cerri at canonical.com: fixed context]
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri at canonical.com>

For both xenial and cosmic:

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>


I have also fixed the bug nominations.

Kleber

> ---
>  block/blk-mq.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 2f8436314985..caeffd5b59f9 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -501,9 +501,6 @@ void blk_mq_free_request(struct request *rq)
>  
>  	wbt_done(q->rq_wb, &rq->issue_stat);
>  
> -	if (blk_rq_rl(rq))
> -		blk_put_rl(blk_rq_rl(rq));
> -
>  	clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags);
>  	clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);
>  	if (rq->tag != -1)
> @@ -1637,8 +1634,6 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
>  {
>  	blk_init_request_from_bio(rq, bio);
>  
> -	blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
> -
>  	blk_account_io_start(rq, true);
>  }
>  
> 




More information about the kernel-team mailing list