NACK: Re: [SRU][Bionic][Cosmic][PATCH 0/1] geneve: Can't create geneve tunnels when ipv6 disabled dynamically

[Nivedita Singhvi]

On 4/17/19 8:03 PM, Nivedita Singhvi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1794232
> 
> SRU Justification
> 
> Impact: Cannot create geneve tunnels if ipv6 is disabled dynamically.
> 
> Fix: 
> Fixed by upstream commit in v5.0:
> Commit: cf1c9ccba7308e48a68fa77f476287d9d614e4c7
> "geneve: correctly handle ipv6.disable module parameter"
>      
> Hence available in Disco and later; required in X,B,C
> Cherry picked and tested successfully for  B, C, with
> X being handled slightly differently, separately. 
>  
> Testcase: 
> 1. Boot with "ipv6.disable=1"
> 2. Then try and create a geneve tunnel using:
>    # ovs-vsctl add-br br1 
>    # ovs-vsctl add-port br1 geneve1 -- set interface geneve1
>     type=geneve options:remote_ip=192.168.x.z // ip of the other host 
> 
> Regression Potential: Low, only geneve tunnels when ipv6 dynamically
> disabled, current status is it doesn't work at all.
> 
> Other Info: 
> * Patch for X being sent separately
> * Mainline commit msg includes reference to a fix for
>   non-metadata tunnels (infrastructure is not yet in 
>   our tree prior to Disco), hence not being included
>   at this time under this case.
> 
>   At this time, all geneve tunnels created as above
>   are metadata-enabled.
> 
> 
> This patch to be applied only to B, C.
>  
> (Note: This SRU request is combining the template at  
>  https://wiki.ubuntu.com/KernelTeam/KernelUpdates and 
>  at https://wiki.ubuntu.com/StableReleaseUpdates)
> 
> 
> Jiri Benc (1):
>   geneve: correctly handle ipv6.disable module parameter
> 
>  drivers/net/geneve.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 

Please defer to next SRU cycle. I'll resubmit as soon as the
window opens.


thanks,
Nivedita