ACK: [X][PATCH 0/2] LP#1822821 TSC clocksource not available in nested guests
Stefan Bader
stefan.bader at canonical.com
Thu Apr 4 09:40:25 UTC 2019
On 02.04.19 19:49, Heitor R. Alves de Siqueira wrote:
> BugLink: https://bugs.launchpad.net/bugs/1822821
>
> [Impact]
> * TSC clocksource not available in nested guests
>
> [Test Case]
> * Spin up a nested Xenial/Bionic guest and check for 'tsc' at
> /sys/devices/system/clocksource/clocksource0/available_clocksource
>
> [Regression Potential]
> * The regression potential is low. Upstream code still maintains this
> behaviour of skipping calibration on guests, and tsc code verifies if
> the frequency is known before registering the clocksource
>
> * Patches were verified against the above test case, and also tested
> with stress-ng in both nested and non-nested guest scenarios
>
> [Fix]
> * By applying the upstream commits, we skip refined calibration and
> register TSC as a clocksource directly if its frequency is known (via
> MSR or CPUID)
>
> [Other Info]
> * Xenial needs 2 patches, Bionic needs 1 patch
> * Cosmic onwards (kernels 4.18+) are already fixed
>
> Bin Gao (1):
> x86/tsc: Add X86_FEATURE_TSC_KNOWN_FREQ flag
>
> Peng Hao (1):
> kvmclock: fix TSC calibration for nested guests
>
> arch/x86/include/asm/cpufeatures.h | 1 +
> arch/x86/kernel/kvmclock.c | 1 +
> arch/x86/kernel/tsc.c | 11 ++++++++---
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20190404/31b6e74a/attachment.sig>
More information about the kernel-team
mailing list