[SRU B][C][PATCH 1/1 v2] UBUNTU: SAUCE: cachefiles: Page leaking in cachefiles_read_backing_file while vmscan is active

[Daniel Axtens]

Hi,

> > If we're just focussing on that function, we can safely leave all 3 of
> > the original hunks from patch v1. I agree that some of the sets of NULL
> > are not strictly necessary and some are missing where you'd expect
> > them. Ideally I'd like to keep the delta between what we have here and
> > what we're hoping will go upstream to a minimum, so how does the
> > following look as both a patch for Ubuntu and a patch for upstream?
>
> Ultimately I would prefer that we apply whatever fix ends up upstream,
> within reason. There's no patch upstream yet however, so I was giving
> some general feedback. If the expectation is that upstream prefers those
> two loops to remain the same, then that's the version we want to
> consider for Ubuntu.

Absolutely, I agree that we want to match upstream.

However, we've had a lot of trouble getting fscache patches into
upstream in any predictable sort of time-frame. This bug is affecting
people at the moment, hence the desire to submit a sauce patch while
the upstream patch is still on the list, in hopes of getting it into
the coming SRU cycle.

I will submit my proposed version both upstream and here first thing
Monday morning.

Regards,
Daniel

>
> Seth