NACK: [SRU][P, T, X, B, C][PATCH] UBUNTU: [Packaging] git-ubuntu-log -- fix order of tracking bug commit

Kleber Souza kleber.souza at canonical.com
Fri Sep 21 11:32:20 UTC 2018


On 09/21/18 12:22, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Sep 21, 2018 at 11:54:48AM +0200, Kleber Sacilotto de Souza wrote:
> [...]
>>  # Suck up the git log output and extract the information we need.
>>  keys = []
>>  entry = None
>> @@ -90,6 +96,10 @@ for key in keys:
>>          for bug in key:
>>              if bug.startswith('CVE-'):
>>                  title_set.append(bug)
>> +            if bug == '__trackingbug__':
>> +                # Look for the tracking bug number on the second
>> +                # position of the key
>> +                continue
>>              else:
>>                  bug_info = None
> 
> Now, you are querying launchpad for CVEs. So, this should be a elif, maybe?
> 
> [...]
> 

Doh... good catch, thanks!

I'll send a v2.




More information about the kernel-team mailing list