ACK/Cmnt: [SRU] [Bionic/Cosmic] [PATCH 0/2] Fix I2C touchpanels' interrupt storms after system suspend

[Stefan Bader]

On 13.09.2018 10:03, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1792309
> 
> [Impact]
> Some I2C touchpanels generate IRQ storm after system suspend/resume.
> 
> [Test]
> After applying the fix, the IRQ storm stops generated by Raydium
> touchpanels.
> 
> [Fix]
> Instead of requesting i2c reset, simply requesting the device to power
> on. The HID over I2C spec doesn't specify how the device should do upon
> resume from suspend, so some devices expect a power on instead of reset.
> 
> [Regression Potential]
> Low. I tested other vendors' touchpanels, didn't observe any side
> effect.
> 
> AceLan Kao (1):
>   HID: i2c-hid: Fix flooded incomplete report after S3 on Rayd
>     touchscreen
> 
> Kai-Heng Feng (1):
>   HID: i2c-hid: Don't reset device upon system resume
> 
>  drivers/hid/hid-ids.h         |  3 ---
>  drivers/hid/i2c-hid/i2c-hid.c | 11 +++++++----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 

I saw you tested other panels, too. Still I feel a little uneasy to change
behaviour generally. As the second patch at least only made it upstream to be
included in 4.19, there is not too much feedback to be expected. At least it got
through upstream so lets bites the bullet for now...

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180913/71ee928e/attachment.sig>