[SRU][bionic][PATCHv2 1/5] powerpc: hard disable irqs in smp_send_stop loop
Kamal Mostafa
kamal at canonical.com
Wed Sep 5 16:17:37 UTC 2018
From: Nicholas Piggin <npiggin at gmail.com>
BugLink: http://bugs.launchpad.net/bugs/1790636
The hard lockup watchdog can fire under local_irq_disable
on platforms with irq soft masking.
Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
(cherry picked from commit 855bfe0de1a05a01f89975ea8ba9f5521fb0f567)
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
arch/powerpc/kernel/smp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index c190d68..7ed7d0c 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -570,9 +570,10 @@ static void stop_this_cpu(void *dummy)
/* Remove this CPU */
set_cpu_online(smp_processor_id(), false);
- local_irq_disable();
+ hard_irq_disable();
+ spin_begin();
while (1)
- ;
+ spin_cpu_relax();
}
#ifdef CONFIG_NMI_IPI
--
2.7.4
More information about the kernel-team
mailing list