NACK: [Bionic][PATCH 0/2] Support for WiFi and Bluetooth LEDs on the Edge Gateways

[Stefan Bader]

On 16.10.18 16:07, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1512997
> BugLink: https://launchpad.net/bugs/1512999
> 
> == Impact ==
> The Wifi and Bluetooth LEDs don't work and keep off all the time on Dell
> Edge Gateway 5000/5100.
> 
> == Fix ==
> The LEDs are connected to GPIO pins on the Marvell WiFi/Bluetooth combo
> module, thus they can only be controlled via firmware.
> 
> These two patches send the commands to the module when the interface turns
> on and off.
> 
> == Test case ==
> # ifconfig wlan0 [on|off]
> # hciconfig hci0 [on|off]
> and see if those LEDs work properly.
> 
> == Risk of Regression ==
> PCI sub IDs of the host bridge are used to determine if we're really
> running on an Edge Gateway, and we already have these patches in Xenial
> kernels quite a while. Risk should be reasonably low.
> 
> 
> 
> Wen-chien Jesse Sung (2):
>   UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the device
>     status
>   UBUNTU: SAUCE: Bluetooth: Support for LED on Edge Gateways
> 
>  drivers/bluetooth/btusb.c                     | 42 ++++++++++++++++++-
>  drivers/net/wireless/marvell/mwifiex/fw.h     | 18 ++++++++
>  drivers/net/wireless/marvell/mwifiex/main.c   |  5 ++-
>  drivers/net/wireless/marvell/mwifiex/main.h   |  6 +++
>  drivers/net/wireless/marvell/mwifiex/pcie.c   | 10 +++++
>  .../net/wireless/marvell/mwifiex/sta_cmd.c    | 29 +++++++++++++
>  .../wireless/marvell/mwifiex/sta_cmdresp.c    |  2 +
>  .../net/wireless/marvell/mwifiex/sta_ioctl.c  | 18 ++++++++
>  8 files changed, 128 insertions(+), 2 deletions(-)
> 
Both bug links refer to bug reports which have been closed already. And while we
are at this (as I said in some other reply) in general one submission to the
mailing list should be for a single bug report. Either duplicate them or create
a new bug report to keep everything together.
Also since the old bug reports were closed a while ago, is this something that
should have gone to Cosmic, too? Or even upstream?

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20181017/a494f126/attachment.sig>