ACK/cmnt: [SRU][Bionic][PATCH 0/1] crypto: vmx - Fix sleep-in-atomic bugs

Joseph Salisbury joseph.salisbury at canonical.com
Mon Oct 15 14:08:21 UTC 2018


On 10/14/2018 12:14 PM, Khaled Elmously wrote:
> On 2018-10-12 14:22:14 , Joseph Salisbury wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1790832
>>
>> == SRU Justification ==
>> IBM is requesting this patch in all releases order to fix the sleep-in-atomic 
>> bugs in AES-CBC and AES-XTS VMX implementations.
>>
>> This patch is a clean cherry pick and has already been applied to
>> Cosmic.  It is also needed in Xenial, but there was a minor context
>> diff, so the Xenial SRU will be sent separatly.  
>>
>> == Fix ==
>> 0522236d4f9c ("crypto: vmx - Fix sleep-in-atomic bugs")
>>
>> == Regression Potential ==
>> Low.  This patch has also been cc'd to upstream stable, so it has had
>> additional upstream review.
>>
>> == Test Case ==
>> A test kernel was built with this patch and tested by the original bug reporter.
>> The bug reporter states the test kernel resolved the bug.
>>
>>
>> Ondrej Mosnacek (1):
>>   crypto: vmx - Fix sleep-in-atomic bugs
>>
>>  drivers/crypto/vmx/aes_cbc.c | 30 ++++++++++++++----------------
>>  drivers/crypto/vmx/aes_xts.c | 21 ++++++++++++++-------
>>  2 files changed, 28 insertions(+), 23 deletions(-)
>>
> Acked-by: Khalid Elmously <khalid.elmously at canonical.com>
>
> I think the expectation for non-clean cherry-picks is to say "backported from XXXXXXXXX" followed by something like [jsalisbury: minor context adjustment] - at least that's what I've been told. I'm fine with it as-is though.

This commit does cherry pick cleanly for both Xenail and Bionic. 
However, the 'git format-patch' output is slightly different for each
kernel after the cherry pick.  This is due to whatever the 'git cherry
pick' does behind the scenes to pick cleanly.  Because I didn't need to
make any changes or do any backporting, I kept the 'cherry picked from'
line for both Xenail and Bionic.  I just SRU'd them separately. 

Do we want to do something different in these cases?


Thanks,

Joe






More information about the kernel-team mailing list