ACK/Cmnt: [PATCH 0/5] [SRU][B/master] Reduce boot noise on Dragonboard

Stefan Bader stefan.bader at canonical.com
Thu Oct 11 09:18:43 UTC 2018


On 10.10.2018 17:32, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1797154
> 
> Impact:
> 
> During boot on a Dragonboard410c using a recent Bionic or Cosmic kernel,
> there's some noise like:
> 
> ...
> [ 3.665431] msm_dsi_phy 1a98300.dsi-phy: Failed to get supply 'vddio':
> -517
> [ 3.669243] msm_dsi_phy 1a98300.dsi-phy: dsi_phy_regulator_init: failed to
> init regulator, ret=-517
> [ 3.676180] msm_dsi_phy 1a98300.dsi-phy: dsi_phy_driver_probe:
> failed to init regulator
> ...
> 
> or
> 
> ...
> [ 4.192280] qcom,pm8916-wcd-spmi-codec 200f000.spmi:pm8916 at 1:codec at f000:
> Failed to get supply 'vdd-cdc-io': -517
> [ 4.195660] qcom,pm8916-wcd-spmi-codec 200f000.spmi:pm8916 at 1:codec at f000:
> Failed to get regulator supplies -517
> ...
> 
> and similar.
> 
> This is mainly due to DRM_MSM* and SND_QCOM_MSM* that were built-in, and try to
> initialize before the voltage regulators are ready to work, resulting in a
> noisy bootlog.
> 
> These patches factor out some code as modules, so when the kmods are loaded and
> initialized, regulators are already present and ready to attach - all these
> config changes shave around ~3K bytes from dmesg, making the bootlog easir to
> parse.
> 
> Fix:
> 
> Apply the attached patches and recompile
> 
> How to test:
> 
> Boot a patched kernel and check for the above noise in dmesg
> 
> Regression potential:
> 
> None, we are just turning some code into kmods, and turning off a couple of not
> used feature for this flavour - all the other flavours are untouched.
> 
> Paolo Pisati (5):
>   UBUNTU: [Config] arm64: snapdragon: DRM_MSM=m
>   UBUNTU: [Config] arm64: snapdragon: SND*=m
>   UBUNTU: [Config] arm64: snapdragon: disable ARM_SDE_INTERFACE
>   UBUNTU: [Config] arm64: snapdragon: disable DRM_I2C_ADV7511_CEC
>   UBUNTU: [Config] arm64: snapdragon: disable VIDEO_ADV7511,
>     VIDEO_COBALT
> 
>  debian.master/config/amd64/config.common.amd64     |  6 ++----
>  debian.master/config/arm64/config.common.arm64     |  7 +++++++
>  debian.master/config/arm64/config.flavour.generic  | 22 ++++------------------
>  .../config/arm64/config.flavour.snapdragon         | 22 ++++------------------
>  debian.master/config/armhf/config.common.armhf     | 14 +++-----------
>  debian.master/config/config.common.ubuntu          | 16 +++++++++++-----
>  debian.master/config/i386/config.common.i386       |  6 ++----
>  debian.master/config/ppc64el/config.common.ppc64el |  7 +++----
>  8 files changed, 36 insertions(+), 64 deletions(-)
> 
I wonder whether all those changes to config should not be reflected (and
possibly enforced) in the annotations file? The changes themselves look okaish...

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20181011/10945a0a/attachment.sig>


More information about the kernel-team mailing list