ACK: [SRU] [Bionic] [PATCH 0/4] Keyboard backlight sysfs sometimes is missing on Dell laptops

Khaled Elmously khalid.elmously at canonical.com
Thu Oct 11 08:51:01 UTC 2018


On 2018-10-11 13:37:04 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1797304
> 
> [Impact]
> When the keyboard backlight sysfs is missing, userspace does not know
> the current keyboard backlight brightness.
> 
> [Fix]
> There's a loading order race condition, between the dell-smbios and its
> backends, dell-smbios-{smm,wmi}.
> Build them as one module can solve the issue.
> 
> The last patch is what we want, but pulls the entire series as a whole.
> 
> [Test]
> The backlight sysfs always exists with the patch. Userspace now knows
> the current keyboard backlight brightness.
> 
> [Regression Potential]
> Low. No functional change, as it simply links the modules together.
> Limits to Dell machines.
> 
> Kai-Heng Feng (1):
>   UBUNTU: [Config] CONFIG_DELL_SMBIOS_SMM=y, CONFIG_DELL_SMBIOS_WMI=y
> 
> Mario Limonciello (3):
>   platform/x86: dell-smbios: Correct some style warnings
>   platform/x86: dell-smbios: Rename dell-smbios source to
>     dell-smbios-base
>   platform/x86: dell-smbios: Link all dell-smbios-* modules together
> 
>  debian.master/config/config.common.ubuntu     |  4 +--
>  drivers/platform/x86/Kconfig                  | 15 ++++++----
>  drivers/platform/x86/Makefile                 |  5 ++--
>  .../x86/{dell-smbios.c => dell-smbios-base.c} | 29 ++++++++++++++++---
>  drivers/platform/x86/dell-smbios-smm.c        | 18 +++---------
>  drivers/platform/x86/dell-smbios-wmi.c        | 14 +++------
>  drivers/platform/x86/dell-smbios.h            | 27 ++++++++++++++++-
>  7 files changed, 74 insertions(+), 38 deletions(-)
>  rename drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} (96%)
>
Acked-by: Khalid Elmously <khalid.elmously at canonical.com>
 




More information about the kernel-team mailing list