ACK/cmt: [linux-aws-bionic][PULL] xen hibernation support for linux-aws

[Colin Ian King]

On 21/11/2018 22:12, Kamal Mostafa wrote:
> BugLink: http://bugs.launchpad.net/bugs/1804533
> 
> AWS-specific xen hibernation support (as is already supported in linux-aws
> Xenial and Trusty) has been ported to linux-aws Bionic by the Amazon team.
> 
> This patch set passes simple hibernation smoke-testing on an instance.
> 
>  -Kamal
> 
> -----
> 
> The following changes since commit 38c16eb14f739889d89a05c3c7753f39fe785ade:
> 
>   UBUNTU: Ubuntu-aws-4.15.0-1028.29 (2018-11-18 23:52:15 -0500)
> 
> are available in the git repository at:
> 
>   git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux-aws/+git/bionic aws-hibernation-lp1804533
> 
> for you to fetch changes up to ef893ba8b23210e2c308cc218c167889a92aabea:
> 
>   UBUNTU: SAUCE [aws] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA (2018-11-21 14:04:39 -0800)
> 
> ----------------------------------------------------------------
> Aleksei Besogonov (1):
>       UBUNTU: SAUCE [aws] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA
> 
> Anchal Agarwal (1):
>       UBUNTU: SAUCE [aws] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume
> 
> Munehisa Kamata (6):
>       UBUNTU: SAUCE [aws] x86/xen: add system core suspend and resume callbacks
>       UBUNTU: SAUCE [aws] xen-netfront: add callbacks for PM suspend and hibernation support
>       UBUNTU: SAUCE [aws] xen-time-introduce-xen_-save-restore-_steal_clock
>       UBUNTU: SAUCE [aws] x86/xen: save and restore steal clock
>       UBUNTU: SAUCE [aws] xen/events: add xen_shutdown_pirqs helper function
>       UBUNTU: SAUCE [aws] x86/xen: close event channels for PIRQs in system core suspend callback
> 
>  arch/x86/xen/enlighten_hvm.c     |  8 ++++
>  arch/x86/xen/suspend.c           | 66 +++++++++++++++++++++++++++
>  arch/x86/xen/time.c              |  3 ++
>  arch/x86/xen/xen-ops.h           |  1 +
>  drivers/net/xen-netfront.c       | 97 +++++++++++++++++++++++++++++++++++++++-
>  drivers/xen/events/events_base.c | 12 +++++
>  drivers/xen/time.c               | 28 +++++++++++-
>  include/xen/events.h             |  1 +
>  include/xen/xen-ops.h            |  4 ++
>  kernel/power/user.c              |  6 ++-
>  10 files changed, 223 insertions(+), 3 deletions(-)
> 

Minor quibble:

UBUNTU: SAUCE [aws] xen-netfront: add callbacks for PM suspend and
hibernation support

+               xenbus_dev_error(dev, err, "Freezing timed out;"
+                                "the device may become inconsistent
state");

there is a missing space between the two split literal strings.


Given that this affects just one specific kernel and that even though
it's several patches that change some core functionality, this is
limited to the PM suspend/hibernate paths so it is limited regression
potential for most of the run time life of a kernel.  Also, some of the
changes address corner case failures so it looks like the more
interesting issues have been worked on to make a workable solution.

I've been informed this has been tested, so I think taking it at face
value these are in working order.. so..

Acked-by: Colin Ian King <colin.king at canonical.com>