[C/D/Unstable] [PATCH 2/2] SAUCE: nvme: add quirk to not call disable function when suspending

Kai-Heng Feng kai.heng.feng at canonical.com
Thu Nov 22 07:15:11 UTC 2018


BugLink: https://bugs.launchpad.net/bugs/1804588

Call nvme_dev_disable() function leads to the power consumption goes up
to 2.8 Watt during suspend-to-idle, and from Intel FE, they suggest us
to use its own APST feature to do the power management during s2idle.

After D3 is diabled and nvme_dev_disable() is not called while
suspending, the power consumption drops 2.8 Watts during s2idle.

Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d5cdd2905a66..714293af7605 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2680,6 +2680,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_VDEVICE(INTEL, 0xf1a5),	/* Intel 600P/P3100 */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_MEDIUM_PRIO_SQ },
+	{ PCI_VDEVICE(INTEL, 0xf1a6),
+		.driver_data = NVME_QUIRK_NO_DISABLE, },
 	{ PCI_VDEVICE(INTEL, 0x5845),	/* Qemu emulated controller */
 		.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
 	{ PCI_DEVICE(0x1bb1, 0x0100),   /* Seagate Nytro Flash Storage */
-- 
2.17.1




More information about the kernel-team mailing list