[DELAY REQ]: [PATCH][unstable][SRU cosmic][SRU bionic] net-next/hinic: add checksum offload and TSO support

dann frazier dann.frazier at canonical.com
Tue Nov 20 00:50:36 UTC 2018


On Wed, Nov 7, 2018 at 10:34 AM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 07.11.18 17:53, dann frazier wrote:
> > On Wed, Nov 7, 2018 at 1:21 AM Stefan Bader <stefan.bader at canonical.com> wrote:
> >>
> >> On 30.10.18 15:04, dann frazier wrote:
> >>> From: Zhao Chen <zhaochen6 at huawei.com>
> >>>
> >>> BugLink: https://bugs.launchpad.net/bugs/1800664
> >>>
> >>> This patch adds checksum offload and TSO support for the HiNIC
> >>> driver. Perfomance test (Iperf) shows more than 100% improvement
> >>> in TCP streams.
> >>>
> >>> Signed-off-by: Zhao Chen <zhaochen6 at huawei.com>
> >>> Signed-off-by: Xue Chaojing <xuechaojing at huawei.com>
> >>> Signed-off-by: David S. Miller <davem at davemloft.net>
> >>> (cherry picked from commit cc18a7543d2f63a2c93fc61cfa7fd8be5464f75e)
> >>> Signed-off-by: dann frazier <dann.frazier at canonical.com>
> >>> ---
> >>
> >> While I am not totally opposed to it due to the limitation to only one driver, I
> >> cannot say how widespread the HW is which is supported (and how many models this
> >> driver covers). This together with the fact that the requested changes come
> >> directly from a very recent upstream source, I would rather wait at least one
> >> additional cycle before we pull this all the way back into Bionic.
> >> So possibly apply to Cosmic now and we can see how that goes. Then follow up
> >> with Bionic later?
> >
> > That seems fair to me, thanks Stefan. Should I resubmit next cycle, or
> > is that unnecessary?
> >
> >   -dann
> >
> We will keep it on the list, so there should be no need to re-submit. But if you
> keep an eye on this and ping us if there is no update the week before starting
> the next cycle, that might be helpful.

Your delay request was prescient - we are seeing an issue w/ longer runs:
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1800664/comments/3

So, self NAK'ing this for bionic until we get to the bottom of that.

  -dann



More information about the kernel-team mailing list