NACK: [SRU][Bionic]Pull Request: Fixes for lp:1787405

[Stefan Bader]

On 08.11.18 23:08, Joseph Salisbury wrote:
> The following changes since commit 513f0ebbc9eb826c40f874506689d1f474766253:
> 
>   UBUNTU: Ubuntu-4.15.0-38.41 (2018-10-10 11:20:36 +0200)
> 
> are available in the Git repository at:
> 
>   kernel.ubuntu.com:/srv/kernel.ubuntu.com/git/jsalisbury/bugs/lp1787405/ubuntu-bionic.git 
> 
> for you to fetch changes up to 7ebd43cce9c0c03b43c9e3b7e495fdfcc6b9f46b:
> 
>   UBUNTU: [Config:] Enable CONFIG_S390_AP_IOMMU and set CONFIG_VFIO_AP to module. (2018-11-08 16:59:48 -0500)
> 
> ----------------------------------------------------------------
> Christian Borntraeger (1):
>       KVM: s390: fix locking for crypto setting error path
> 
> David Hildenbrand (2):
>       KVM: s390: vsie: simulate VCPU SIE entry/exit
>       KVM: s390: introduce and use KVM_REQ_VSIE_RESTART
> 
> Harald Freudenberger (9):
>       s390/zcrypt: Add ZAPQ inline function.
>       s390/zcrypt: Review inline assembler constraints.
>       s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h.
>       s390/zcrypt: fix ap_instructions_available() returncodes
>       s390/zcrypt: AP bus support for alternate driver(s)
>       s390/zcrypt: hex string mask improvements for apmask and aqmask.
>       s390/zcrypt: Remove deprecated ioctls.
>       s390/zcrypt: Remove deprecated zcrypt proc interface.
>       s390/zcrypt: Support up to 256 crypto adapters.
> 
> Joseph Salisbury (1):
>       UBUNTU: [Config:] Enable CONFIG_S390_AP_IOMMU and set CONFIG_VFIO_AP to module.
> 
> Martin Schwidefsky (1):
>       s390/zcrypt: remove VLA usage from the AP bus
> 
> Pierre Morel (11):
>       KVM: s390: Clear Crypto Control Block when using vSIE
>       KVM: s390: vsie: Do the CRYCB validation first
>       KVM: s390: vsie: Make use of CRYCB FORMAT2 clear
>       KVM: s390: vsie: Allow CRYCB FORMAT-2
>       KVM: s390: vsie: allow CRYCB FORMAT-1
>       KVM: s390: vsie: allow CRYCB FORMAT-0
>       KVM: s390: vsie: allow guest FORMAT-0 CRYCB on host FORMAT-1
>       KVM: s390: vsie: allow guest FORMAT-1 CRYCB on host FORMAT-2
>       KVM: s390: vsie: allow guest FORMAT-0 CRYCB on host FORMAT-2
>       KVM: s390: Tracing APCB changes
>       s390: vfio-ap: setup APCB mask using KVM dedicated function
> 
> Tony Krowiak (16):
>       KVM: s390: reset crypto attributes for all vcpus
>       KVM: s390: refactor crypto initialization
>       s390: vfio-ap: base implementation of VFIO AP device driver
>       s390: vfio-ap: register matrix device with VFIO mdev framework
>       s390: vfio-ap: sysfs interfaces to configure adapters
>       s390: vfio-ap: sysfs interfaces to configure domains
>       s390: vfio-ap: sysfs interfaces to configure control domains
>       s390: vfio-ap: sysfs interface to view matrix mdev matrix
>       KVM: s390: interface to clear CRYCB masks
>       s390: vfio-ap: implement mediated device open callback
>       s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl
>       s390: vfio-ap: zeroize the AP queues
>       s390: vfio-ap: implement VFIO_DEVICE_RESET ioctl
>       KVM: s390: device attrs to enable/disable AP interpretation
>       KVM: s390: CPU model support for AP virtualization
>       s390: doc: detailed specifications for AP virtualization
> 
>  Documentation/s390/vfio-ap.txt                 | 837 ++++++++++++++++++++++
>  MAINTAINERS                                    |  12 +
>  arch/s390/Kconfig                              |  11 +
>  arch/s390/include/asm/ap.h                     | 290 +++++++-
>  arch/s390/include/asm/kvm_host.h               |   9 +
>  arch/s390/include/uapi/asm/kvm.h               |   2 +
>  arch/s390/include/uapi/asm/zcrypt.h            | 163 ++---
>  arch/s390/kvm/kvm-s390.c                       | 195 +++--
>  arch/s390/kvm/kvm-s390.h                       |  14 +
>  arch/s390/kvm/vsie.c                           | 208 +++++-
>  arch/s390/tools/gen_facilities.c               |   2 +
>  debian.master/config/s390x/config.common.s390x |   2 +
>  drivers/iommu/Kconfig                          |   8 +
>  drivers/s390/crypto/Makefile                   |   4 +
>  drivers/s390/crypto/ap_asm.h                   | 236 -------
>  drivers/s390/crypto/ap_bus.c                   | 360 +++++++++-
>  drivers/s390/crypto/ap_bus.h                   |  35 +-
>  drivers/s390/crypto/ap_card.c                  |   1 -
>  drivers/s390/crypto/ap_queue.c                 |  20 -
>  drivers/s390/crypto/pkey_api.c                 |  41 +-
>  drivers/s390/crypto/vfio_ap_drv.c              | 157 +++++
>  drivers/s390/crypto/vfio_ap_ops.c              | 939 +++++++++++++++++++++++++
>  drivers/s390/crypto/vfio_ap_private.h          |  88 +++
>  drivers/s390/crypto/zcrypt_api.c               | 471 ++++---------
>  drivers/s390/crypto/zcrypt_api.h               |  26 +-
>  drivers/s390/crypto/zcrypt_cex2a.c             |   2 +
>  drivers/s390/crypto/zcrypt_cex4.c              |   2 +
>  drivers/s390/crypto/zcrypt_pcixcc.c            |   2 +
>  include/uapi/linux/vfio.h                      |   2 +
>  29 files changed, 3294 insertions(+), 845 deletions(-)
>  create mode 100644 Documentation/s390/vfio-ap.txt
>  delete mode 100644 drivers/s390/crypto/ap_asm.h
>  create mode 100644 drivers/s390/crypto/vfio_ap_drv.c
>  create mode 100644 drivers/s390/crypto/vfio_ap_ops.c
>  create mode 100644 drivers/s390/crypto/vfio_ap_private.h
> 
This is a very big change, even within one arch and supposedly tested. But this
is bypassing the normal development process. At least we should have all this in
Disco before backporting.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20181109/b9a5017f/attachment-0001.sig>