ACK+cmnt: [SRU X][PATCH v2 0/3] Add kernel parameter 'pci=clearmsi' to clear MSI(X)s early on boot

[Mauricio Faria de Oliveira]

On Thu, Nov 8, 2018 at 12:56 PM Thadeu Lima de Souza Cascardo <
cascardo at canonical.com> wrote:

> That's not the most clear way of doing this. You are still calling the
> quirk
> for all devices on bus 0, and getting out if the option was off. I would
> not call an operation done for any/all devices a quirk, so would
> definitively do it as a new function.
>

No worries, I agree and I get it.  In fact, Guilherme had a different patch
that would do something similar to what you say, however, that is somewhat
different from what was posted upstream, and I was asked to post the
upstream-based version (for that's what has been reviewed previously)
while Guilherme is out on vacation; so, that's why I have just moved
things around, which makes the quirk still to be called, but it bails out.


> But I may be accused of bikeshedding or nitpicking, so I'll give my ACK.
>

Understand :)  Thanks.

Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
>


-- 
Mauricio Faria de Oliveira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20181108/393fac37/attachment.html>