[SRU] [Bionic/Cosmic] [PATCH 0/1] Enable keyboard wakeup for S2Idle laptops

Kai Heng Feng kai.heng.feng at canonical.com
Thu Nov 8 11:50:59 UTC 2018



> On Nov 6, 2018, at 20:59, Stefan Bader <stefan.bader at canonical.com> wrote:
> 
> On 18.10.18 11:14, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1798552
>> 
>> [Impact]
>> Laptops default to S2Idle can't be woken up by keyboard during suspend.
>> Most laptops can be woken up by keyboard in S3. To align the behavior,
>> let's do the same for S2Idle laptops.
>> 
>> [Fix]
>> Set the serio keyboard wakeup to "enabled" as default.
>> 
>> [Test]
>> With this patch, XPS 9370 can be woken up by its keyboard during
>> suspend.
>> 
>> [Regression Potential]
>> Low. This has the same effect as chaging sysfs knob "power/wakeup" from
>> "disabled" to "enabled".
>> 
>> [Note]
>> The commit can be cleanly cherry-picked to both Cosmic and Bionic, but the
>> formatted patch from Bionic can not be applied to Cosmic and vise versa.
>> So I created two clean cherry-pickes for both series.
>> 
>> Daniel Drake (1):
>>  Input: i8042 - enable keyboard wakeups by default when s2idle is used
>> 
>> drivers/input/serio/i8042.c | 29 ++++++++++++++++++++---------
>> include/linux/suspend.h     |  2 ++
>> kernel/power/suspend.c      |  6 ++++++
>> 3 files changed, 28 insertions(+), 9 deletions(-)
>> 
> Is this really a cherry pick for Cosmic and Bionic? If so why submitting twice?

I stated the reason in the [Note] section.

I have no idea why `git cherry-pick` works but `git am` formatted patch does not.
That’s why I created two separate clean cherry-picks.

Kai-Heng

> 
> -Stefan




More information about the kernel-team mailing list