ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

[Shrirang Bagul]

Hi Siva,
Let's continue the discussion on the bug: https://bugs.launchpad.net/plano/+bug/1769225 and not on the mailing list.See my comment. https://bugs.launc
hpad.net/plano/+bug/1769225/comments/66
/ShrirangOn Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote:
> Thanks for the update. And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.
> 
> Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.
> 
> Best regards,
> Siva Rebbagondla
> On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <shrirang.bagul at canonical.com> wrote:
> > Hi Siva,
> > Well, the status has changed since my previous email on this thread.Because, the test kernel built with these patches still doesn't fix the issue,
> > I'm not sure if these patches should be merged at all.
> > /Shrirang
> > On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:
> > > Hi Shrirang,
> > > 
> > > Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/".
> > > Do i need to resend the patches one again?. Please confirm this.
> > > 
> > > Snippet from above URL, which shows ACK for submitted patches.
> > > 
> > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue
> > >  
> > > Shrirang Bagul
> > > 
> > > 
> > > ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue
> > >  
> > > Siva Rebbagondla
> > > 
> > > 
> > > Thank you,
> > > Siva Rebbagondla.
> > > 
> > > On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <siva8118 at gmail.com> wrote:
> > > > Hi Shrirang,
> > > > 
> > > > I just sent a subscription request to ubuntu kernel team.
> > > > 
> > > > Thanks,
> > > > Siva Rebbagondla
> > > > 
> > > > On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <shrirang.bagul at canonical.com> wrote:
> > > > > Hi Siva,
> > > > > 
> > > > > Looks like the email address you are using to send patches was not registered in the kernel-team at lists.ubuntu.com mailing list.
> > > > > The patches submitted in this series are under moderation and won't get picked-up.
> > > > > 
> > > > > Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend
> > > > > the patches.
> > > > > 
> > > > > /Shrirang
> > > > > On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:
> > > > > > On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <shrirang.bagul at canonical.com> wrote:
> > > > > > > On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> > > > > > > 
> > > > > > > > From: Sanjay Kumar Konduri <sanjay.konduri at redpinesignals.com>
> > > > > > > 
> > > > > > > > 
> > > > > > > 
> > > > > > > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> > > > > > > 
> > > > > > > > 
> > > > > > > 
> > > > > > > > Observed third party station is unable to scan redpine AP, when Soft-AP
> > > > > > > 
> > > > > > > > restart command invoked. This is because power save is not disabled for
> > > > > > > 
> > > > > > > > rsi Soft-AP mode in rsi_mac80211_tx().
> > > > > > > 
> > > > > > > > 
> > > > > > > 
> > > > > > > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri at redpinesignals.com>
> > > > > > > 
> > > > > > > > Signed-off-by: Siva Rebbagondla <siva.rebbagondla at redpinesignals.com>
> > > > > > > 
> > > > > > > When you have multiple patches addressing different bugs, it's advisable to 
> > > > > > > 
> > > > > > > include a cover letter with a short explanation. Otherwise, everything looks
> > > > > > > 
> > > > > > > okay.
> > > > > >  Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks  
> > > > > > > 
> > > > > > > Acked-by: Shrirang Bagul <shrirang.bagul at canonical.com>
> > > > > > > 
> > > > > > > > ---
> > > > > > > 
> > > > > > > > v2: Changed the subject as per stable patch format [Shrirang].
> > > > > > > 
> > > > > > > > ---
> > > > > > > 
> > > > > > > >  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
> > > > > > > 
> > > > > > > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > > > > > 
> > > > > > > > 
> > > > > > > 
> > > > > > > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> > > > > > > 
> > > > > > > > index 129859a..244ef27 100644
> > > > > > > 
> > > > > > > > --- a/ubuntu/rsi/rsi_91x_mac80211.c
> > > > > > > 
> > > > > > > > +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> > > > > > > 
> > > > > > > > @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
> > > > > > > 
> > > > > > > >               return;
> > > > > > > 
> > > > > > > >       }
> > > > > > > 
> > > > > > > >       if ((!bss->assoc) &&
> > > > > > > 
> > > > > > > > -         (adapter->ps_state == PS_ENABLED) &&
> > > > > > > 
> > > > > > > > -         (vif->type == NL80211_IFTYPE_STATION))
> > > > > > > 
> > > > > > > > +         (adapter->ps_state == PS_ENABLED))
> > > > > > > 
> > > > > > > >               rsi_disable_ps(adapter);
> > > > > > > 
> > > > > > > >       if (ieee80211_is_auth(wlh->frame_control))
> > > > > > > 
> > > > > > > >               common->mac_ops_resumed = false;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180531/bece9946/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180531/bece9946/attachment.sig>