ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Shrirang Bagul shrirang.bagul at canonical.com
Mon May 28 12:32:44 UTC 2018


On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <sanjay.konduri at redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> 
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
> 
> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri at redpinesignals.com>
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla at redpinesignals.com>
When you have multiple patches addressing different bugs, it's advisable to 
include a cover letter with a short explanation. Otherwise, everything looks
okay.
 
Acked-by: Shrirang Bagul <shrirang.bagul at canonical.com>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>  		return;
>  	}
>  	if ((!bss->assoc) &&
> -	    (adapter->ps_state == PS_ENABLED) &&
> -	    (vif->type == NL80211_IFTYPE_STATION))
> +	    (adapter->ps_state == PS_ENABLED))
>  		rsi_disable_ps(adapter);
>  	if (ieee80211_is_auth(wlh->frame_control))
>  		common->mac_ops_resumed = false;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20180528/a2439d68/attachment.sig>


More information about the kernel-team mailing list