ACK: [PATCH 0/2][SRU][Bionic] UBUNTU: SAUCE: Adding back alx WoL feature
khalid.elmously at canonical.com
Wed May 23 02:37:22 UTC 2018
On 2018-05-23 09:56:48 , AceLan Kao wrote:
> BugLink: BugLink: https://launchpad.net/bugs/1772610
> The WoL feature is a must to pass Energy Star 6.1 and above.
> The power consumption will be measured during S3 with WoL is enabled.
> [Test case]
> Verified pass on new Dell machines without the wake up issue.
> [Regression potential]
> No regression.
> We disable this feature by default, so the driver behavior will be the same. We'll leave this feature disabled by default before we can fix the unintentional wake up issue.
> Upstream maintainer insists to fix the wake up issue before we can add this feature back to the driver, so make the patch stay in Ubuntu kernel only. We'll verify WoL on every new machines and try to fix this issue when we encounter it.
> AceLan Kao (2):
> Revert "alx: remove WoL support"
> alx: add disable_wol paramenter
> drivers/net/ethernet/atheros/alx/ethtool.c | 41 ++++++
> drivers/net/ethernet/atheros/alx/hw.c | 154 ++++++++++++++++++++-
> drivers/net/ethernet/atheros/alx/hw.h | 5 +
> drivers/net/ethernet/atheros/alx/main.c | 147 ++++++++++++++++++--
> 4 files changed, 336 insertions(+), 11 deletions(-)
Acked-by: Khalid Elmously <khalid.elmously at canonical.com>
More information about the kernel-team