ACK/mnt: [SRU][Bionic][v2] Pull Request: Fixes for lp:1770003

[Kleber Souza]

On 05/16/18 19:02, Joseph Salisbury wrote:
> == SRU Justification ==
> IBM is requesting these nine patches to be SRU'd to Bionic.  IBM found
> that the current Bionic kernel contains a problem related to qla2xxx
> driver which causes the following:
> 
> #####
> [ 66.295233] Unable to handle kernel paging request for data at address 0x8882f6ed90e9151a
> [ 66.295297] Faulting instruction address: 0xc00000000038a110
> cpu 0x50: Vector: 380 (Data Access Out of Range) at [c00000000692f650]
>     pc: c00000000038a110: kmem_cache_alloc_node+0x2f0/0x350
>     lr: c00000000038a0fc: kmem_cache_alloc_node+0x2dc/0x350
>     sp: c00000000692f8d0
>    msr: 9000000000009033
>    dar: 8882f6ed90e9151a
>   current = 0xc00000000698fd00
>   paca = 0xc00000000fab7000 softe: 0 irq_happened: 0x01
>     pid = 1762, comm = systemd-journal
> Linux version 4.15.0-20-generic (buildd at bos02-ppc64el-002) (gcc version 7.3.0 (Ubuntu 7.3.0-14ubuntu1)) #16-Ubuntu SMP Wed Apr 4 13:57:51 UTC 2018 (Ubuntu 4.15.0-20.21-generic 4.15.20)
> enter ? for help
> [c00000000692f8d0] c000000000389fd4 kmem_cache_alloc_node+0x1b4/0x350 (unreliable)
> [c00000000692f940] c000000000b2ec6c __alloc_skb+0x6c/0x220
> [c00000000692f9a0] c000000000b30b6c alloc_skb_with_frags+0x7c/0x2e0
> [c00000000692fa30] c000000000b247cc sock_alloc_send_pskb+0x29c/0x2c0
> [c00000000692fae0] c000000000c5705c unix_dgram_sendmsg+0x15c/0x8f0
> [c00000000692fbc0] c000000000b1ec64 sock_sendmsg+0x64/0x90
> [c00000000692fbf0] c000000000b20abc ___sys_sendmsg+0x31c/0x390
> [c00000000692fd90] c000000000b221ec __sys_sendmsg+0x5c/0xc0
> [c00000000692fe30] c00000000000b184 system_call+0x58/0x6c
> --- Exception: c00 (System Call) at 000074826f6fa9c4
> SP (7ffff5dc5510) is in userspace
> #####
> 
> Four of the patches in this pull request were back ported by IBM.  The other
> five were clean picks.

I'm giving my ACK but I would like to hear the thoughts of some other
member of the team. The patches look good, seem to be beneficial and
with relatively low regression potential, but not all of them appear to
be directly related to the issue reported on the bug.

> 
> == Regression Potential ==
> Medium.  There are nine patches in this pull request.  They are not specific to a
> paticular arch, but they are specific to qla2xxx.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by IBM.
> IBM states the test kernel resolved the bug.
> 
> 
> 
> 
> The following changes since commit d4174baeefbd0a9634291145600b90e13163f27d:
> 
>   UBUNTU: Ubuntu-4.15.0-20.21 (2018-04-23 23:56:56 -0500)
> 
> are available in the Git repository at:
> 
>   kernel.ubuntu.com:/srv/kernel.ubuntu.com/git/jsalisbury/bugs/lp1770003/ubuntu-bionic.git 
> 
> for you to fetch changes up to 35807f390479db2f61453e940a01deffa878147e:
> 
>   scsi: qla2xxx: Fixup locking for session deletion (2018-05-16 12:55:47 -0400)
> 
> ----------------------------------------------------------------
> Giridhar Malavali (1):
>       scsi: qla2xxx: Don't call dma_free_coherent with IRQ disabled.
> 
> Hannes Reinecke (1):
>       scsi: qla2xxx: Fixup locking for session deletion

The above patch states:
(backported from upstream ZFS commit
1c6cacf4ea6c04a58a0e3057f5ed60c24a4ffeff)

However, it has already landed on Linus' tree, so the "upstream ZFS"
part can be removed when applying it.

> 
> Quinn Tran (6):
>       scsi: qla2xxx: Fix session cleanup for N2N
>       scsi: qla2xxx: Remove unused argument from qlt_schedule_sess_for_deletion()
>       scsi: qla2xxx: Serialize session deletion by using work_lock
>       scsi: qla2xxx: Serialize session free in qlt_free_session_done
>       scsi: qla2xxx: Prevent relogin trigger from sending too many commands
>       scsi: qla2xxx: Fix double free bug after firmware timeout
> 
> himanshu.madhani at cavium.com (1):
>       scsi: qla2xxx: Fix warning in qla2x00_async_iocb_timeout()
> 
>  drivers/scsi/qla2xxx/qla_def.h    |  17 +-
>  drivers/scsi/qla2xxx/qla_fw.h     |   2 +-
>  drivers/scsi/qla2xxx/qla_gbl.h    |   3 +-
>  drivers/scsi/qla2xxx/qla_gs.c     |  17 +-
>  drivers/scsi/qla2xxx/qla_init.c   | 231 ++++++++++++++-----------
>  drivers/scsi/qla2xxx/qla_isr.c    |   8 +-
>  drivers/scsi/qla2xxx/qla_mbx.c    |  38 ++++-
>  drivers/scsi/qla2xxx/qla_os.c     |  56 +++++--
>  drivers/scsi/qla2xxx/qla_target.c | 343 +++++++++++++++++++++++++-------------
>  9 files changed, 466 insertions(+), 249 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>


Thanks,
Kleber