NAK[T]: [T/X/A/B/C][PATCH 0/1] CVE-2018-1092
khalid.elmously at canonical.com
Wed May 16 19:26:19 UTC 2018
On 2018-05-16 23:24:37 , Po-Hsu Lin wrote:
> Although this can be cherry-picked for Trusty cleanly,
> it adds an undeclared marco here "EFSCORRUPTED" and triggers build error from
> the compiler:
> /home/phlin/ubuntu-trusty/fs/ext4/inode.c: In function 'ext4_iget':
> /home/phlin/ubuntu-trusty/fs/ext4/inode.c:4137:10: error: 'EFSCORRUPTED' undeclared (first use in this function)
> ret = -EFSCORRUPTED;
> /home/phlin/ubuntu-trusty/fs/ext4/inode.c:4137:10: note: each undeclared identifier is reported only once for each function it appears in
> CC [M] sound/pci/ice1712/maya44.o
> make: *** [fs/ext4/inode.o] Error 1
> This was only defined for xfs in Trusty:
> phlin at tangerine:~/ubuntu-trusty$ git grep "define EFSCORRUPTED"
> fs/xfs/xfs_linux.h:#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> For X/A/B, it's defined in ext4.h as well.
> Thus I'm gonna put my NAK on Trusty only.
Yes, good catch, thank you.
NACK for Trusty. I will send a v2 specifically for Trusty - thanks.
More information about the kernel-team