ACK/cmnt: [SRU][Artful][PATCH 0/2][v3] Fixes for LP:1746474

[Khalid Elmously]

On 2018-05-07 17:23:12 , Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1746474
> 
> == SRU Justification ==
> Commit 52df157f17e5 introduced a regression in v4.13-rc1.  This regression
> causes a stack trace to occur when tearing down an LXD container.  The process
> hangs with the following message:
> 
> "unregister_netdevice: waiting for eth0 to become free. Usage count = 5"
> 
> This regression is fixed by commit 510c321b5571, which is in mainline as of
> v4.16-rc7.  The fix is needed in Artful and Bionic.  However, Artful needs
> commit 9620fef27ed2 as a prereq commit, so it's SRU request es beinsss sent separately.
> 
> 
> == Fixes ==
> 9620fef27ed2 ("ipv4: convert dst_metrics.refcnt from atomic_t to refcount_t")
> 510c321b5571 ("xfrm: reuse uncached_list to track xdsts")
> 
> == Regression Potential ==
> Low.  This commit is to fix a current regression.
> 
> == Test Case ==
> A test kernel was built with these patches and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> 
> Eric Dumazet (1):
>   ipv4: convert dst_metrics.refcnt from atomic_t to refcount_t
> 
> Xin Long (1):
>   xfrm: reuse uncached_list to track xdsts
> 
>  include/net/dst.h        |  3 ++-
>  include/net/ip6_route.h  |  2 ++
>  include/net/route.h      |  3 +++
>  net/core/dst.c           |  6 +++---
>  net/ipv4/fib_semantics.c |  4 ++--
>  net/ipv4/route.c         | 23 ++++++++++++++---------
>  net/ipv4/xfrm4_policy.c  |  4 +++-
>  net/ipv6/route.c         |  4 ++--
>  net/ipv6/xfrm6_policy.c  |  4 ++++
>  9 files changed, 35 insertions(+), 18 deletions(-)
> 

I guess since it's intentional:  
Acked-by: Khalid Elmously <khalid.elmously at canonical.com>


But I'm still not sure why drop the statistic-keeping. Do we not care about stats for some reason?

-Khalid