NACK: [linux-kvm-x][PATCH] enable CONFIG_DEBUG_RODATA

[Po-Hsu Lin]

ooops, sorry for the copy paste, hehe
I will resubmit V2 for this.

On Mon, May 7, 2018 at 2:56 PM, Stefan Bader <stefan.bader at canonical.com> wrote:
> On 07.05.2018 08:41, Po-Hsu Lin wrote:
>> == Justification ==
>> In the Bionic KVM and Xenial KVM kernel, the CONFIG_MODULE_UNLOAD was not set, this will cause the rmmod command in test_072_strict_devmem test from the kernel security test suite fail to run, and induce a failure in the following test_140_kernel_modules_not_tainted test.
>
> You are not really consistent about which option to change. Which causes me to
> not really being sure whether I like it... ;)
>
> -Stefan
>
>>
>> == Test ==
>> Before enabling the config, rmmod command will return:
>> "ERROR: Module signpost is in use"
>> After the config was enabled, rmmod will succeed and it will pass with this test_140_kernel_modules_not_tainted test.
>>
>> == Fix ==
>> Set CONFIG_MODULE_UNLOAD to "y" to allow user to unload a module.
>>
>> == Regression Potential ==
>> Minimal.
>> No code changes, just one config change without disabling any other configs.
>>
>> BugLink: http://bugs.launchpad.net/bugs/1760643
>>
>> Po-Hsu Lin (1):
>>   UBUNTU: kvm: [config] enable CONFIG_DEBUG_RODATA
>>
>>  debian.kvm/config/config.common.ubuntu | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>
>